Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct label for persistent object cache Site Health check #329

Merged
merged 2 commits into from
May 10, 2022
Merged

Correct label for persistent object cache Site Health check #329

merged 2 commits into from
May 10, 2022

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented May 9, 2022 •
edited by felixarntz
Loading

Fixes #328

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mxbclang mxbclang added [Type] Bug An existing feature is broken [Focus] Object Cache labels May 9, 2022
@mxbclang mxbclang added no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Bug An existing feature is broken labels May 9, 2022
@tillkruss tillkruss added [Type] Bug An existing feature is broken and removed [Type] Enhancement A suggestion for improvement of an existing feature labels May 9, 2022
@tillkruss tillkruss added this to the 1.1.0 milestone May 9, 2022
felixarntz
felixarntz reviewed May 9, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 One small thing to address here, other than that lgtm.

modules/object-cache/persistent-object-cache-health-check/load.php Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request May 10, 2022
Merged
3 tasks
felixarntz
felixarntz approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27!

@felixarntz felixarntz merged commit 7e336d0 into WordPress:trunk May 10, 2022
@felixarntz felixarntz changed the title Correct persistent object cache label Correct label for persistent object cache Site Health check May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@tillkruss tillkruss tillkruss approved these changes

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Assignees

@felixarntz felixarntz

Labels
no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Correct persistent object cache label
6 participants
@mukeshpanchal27 @spacedmonkey @tillkruss @felixarntz @mxbclang @eclarke1