Include generated module-i18n.php file in repository #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#59 introduced a generated
module-i18n.php
file that contains all the available module names and descriptions so that these are recognized as translatable strings in the plugin repository. This file was originally.gitignore
d, however that was not fully thought through.The release instructions state that updating these strings is part of the release tasks, and our automated deployment task relies on all relevant files being part of the repository.
So, while this is a generated file, we should still include it in the repository. This makes deployment straightforward, as without this PR the plugin would be missing the file. The change furthermore ensures that the plugin still works even when somebody downloads it manually from GitHub as a ZIP file.
Relevant technical choices
module-i18n.php
from.gitignore
.Web Support
module name (should beWebP Support
).npm run translations
).Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.