Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include generated module-i18n.php file in repository #196

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

felixarntz
Copy link
Member

@felixarntz felixarntz commented Feb 28, 2022

Summary

#59 introduced a generated module-i18n.php file that contains all the available module names and descriptions so that these are recognized as translatable strings in the plugin repository. This file was originally .gitignored, however that was not fully thought through.

The release instructions state that updating these strings is part of the release tasks, and our automated deployment task relies on all relevant files being part of the repository.

So, while this is a generated file, we should still include it in the repository. This makes deployment straightforward, as without this PR the plugin would be missing the file. The change furthermore ensures that the plugin still works even when somebody downloads it manually from GitHub as a ZIP file.

Relevant technical choices

  • Remove module-i18n.php from .gitignore.
  • Fix typo in Web Support module name (should be WebP Support).
  • Make sure all strings in the file are their latest versions (by running npm run translations).

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure Needs Review labels Feb 28, 2022
@felixarntz felixarntz added this to the 1.0.0-beta.1 milestone Feb 28, 2022
@felixarntz felixarntz merged commit 76c1d49 into trunk Feb 28, 2022
@tillkruss tillkruss deleted the add/module-i18n-file branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants