-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition bug where activating multiple features sequentially could fail to activate some features #1675
Fix race condition bug where activating multiple features sequentially could fail to activate some features #1675
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @b1ink0 for the PR.
When plugins are activated simultaneously, while some plugins in the waiting
state reloading the settings page. After the reload, some plugins display the Activate
button again, even though they are already installed and activated, while others remain unactivated.
This is not a blocker but something I observed during testing.
Screen.Recording.2024-11-19.at.5.11.14.PM.mov
@mukeshpanchal27 demo-3.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI I've changed the base branch to a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b1ink0 This looks great, thank you for the fix and fast turnaround time!
Summary
Fixes #1660
Relevant technical choices
Implemented a queue based approach for activation of features / plugins using the AJAX in JavaScript.
Now only one features / plugin sends a request at a time other request are processed after previous request is finished.
Demo
demo-2.mp4