Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging stored URL Metrics in Optimization Detective #1656

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Nov 15, 2024

While all of the URL Metrics are dumped out as part of the collection, it makes it difficult to drill down to see what the most recently-stored URL Metrics are. This is improved here, including a creationDate property which includes a Date instance of the timestamp:

image

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Nov 15, 2024
@westonruter westonruter marked this pull request as ready for review November 15, 2024 23:22
Copy link

github-actions bot commented Nov 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter changed the title Improve debugging with Optimization Detective Improve debugging stored URL Metrics in Optimization Detective Nov 15, 2024
@westonruter
Copy link
Member Author

@felixarntz Does this look good to you?

Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty!

@westonruter westonruter merged commit 094ef41 into trunk Dec 13, 2024
8 checks passed
@westonruter westonruter deleted the improve/od-debugging branch December 13, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Done 😃
Development

Successfully merging this pull request may close these issues.

2 participants