Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary question marks from checkbox labels #110

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

tillkruss
Copy link
Member

@tillkruss tillkruss commented Jan 19, 2022

Summary

It's not really common to add a question mark to checkboxes, in WordPress or elsewhere.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@tillkruss tillkruss added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jan 19, 2022
@tillkruss tillkruss added this to the 1.0.0-beta.1 milestone Jan 19, 2022
@tillkruss tillkruss requested a review from felixarntz as a code owner January 19, 2022 20:48
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Preferably we should have an issue for PRs, but this is so simple it should be fine. Alternatively it could be a follow-up PR to #30. But all good :)

@aristath aristath merged commit 50d740d into trunk Jan 20, 2022
@aristath aristath deleted the fix/remove-module-questionmark branch January 20, 2022 09:50
@felixarntz felixarntz changed the title Update load.php Remove unnecessary question marks in checkbox labels Jan 28, 2022
@felixarntz felixarntz changed the title Remove unnecessary question marks in checkbox labels Remove unnecessary question marks from checkbox labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants