Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an image is edited, perform updates only to the specified target #299

Closed
mitogh opened this issue Apr 15, 2022 · 1 comment · Fixed by #301
Closed

When an image is edited, perform updates only to the specified target #299

mitogh opened this issue Apr 15, 2022 · 1 comment · Fixed by #301
Assignees
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Milestone

Comments

@mitogh
Copy link
Member

mitogh commented Apr 15, 2022

Feature Description

This is a follow up issue from

When an image is edited a user is able to select multiple targets from the edit screen (see attached screenshot).

2022-04-14_21-03

The edits can happen to:

  • All the images
  • Thumbnail - Only the thumbnail image is updated
  • All sizes except the thumbnail

When either of those targets are selected, make sure that only the target is modified and subsequent edits uses the specified source.

All images

This is the current behavior and when an edit takes place all the subsizes as well with the full image source is modified applying the specified updates, all the available mime types should reflect this change as well besides the default mime type.

Thumbnail

Only the thumbnail size is modified, the rest of the image sizes remains the same, the thumbnail and sources for the thumbnail should reflect this change making sure all the specified mime types create a source with the same details as the primary mime type for the image.

All sizes except the thumbnail

This behavior is similar to all images, with the difference that the changes shouldn't be applied to thumbnail image sizes and sources for that subsize.

All the available subsizes, including the full image size should be modified with the specified changes, and the sources property should be created for all the specified mime types.

@mitogh mitogh added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Apr 15, 2022
@felixarntz felixarntz added the Needs Dev Anything that requires development (e.g. a pull request) label Apr 15, 2022
@felixarntz felixarntz added this to the First release after 1.0.0 milestone Apr 15, 2022
@mitogh mitogh self-assigned this Apr 16, 2022
@mitogh mitogh added Needs Review and removed Needs Dev Anything that requires development (e.g. a pull request) labels Apr 16, 2022
mitogh added a commit that referenced this issue Apr 16, 2022
When an image is selected for a target make sure that only
the selected target images are processed instead of processing
all the images when is not required or desired.

Fixes #299
@mxbclang mxbclang assigned mehulkaklotar and unassigned mitogh May 11, 2022
@felixarntz
Copy link
Member

Fixed via #301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants