Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Translations: Only respect the locale when it's a valid locale. #626

Merged
merged 1 commit into from
Feb 28, 2024
Merged

API: Translations: Only respect the locale when it's a valid locale. #626

merged 1 commit into from
Feb 28, 2024

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 28, 2024

Fixes #625

How to test the changes in this Pull Request:

  1. See Add support for creating patterns for templates, using template types #615, make request
  2. Duplicate warning
  3. Apply PR
  4. Validate warning no longer present.

@dd32 dd32 added [Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint i18n Translations and internationalization of patterns labels Feb 28, 2024
@dd32 dd32 requested a review from pkevan February 28, 2024 05:32
@dd32 dd32 mentioned this pull request Feb 28, 2024
Closed
pkevan
pkevan approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested and fixes the fatal

@pkevan pkevan merged commit a01fb7b into trunk Feb 28, 2024
3 checks passed
@pkevan pkevan deleted the fix/625-fatal-locale branch February 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkevan pkevan pkevan approved these changes

Assignees
No one assigned
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint i18n Translations and internationalization of patterns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locale parameter cause fatal error
2 participants
@dd32 @pkevan