This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to memoize the result of the i18n module's central
dcnpgettext
function. This improves performance of a simple call to__
by roughly 26000% .Before:
After:
The root of the performance issue is Jed's
Jed.PF.compile
function, which compiles a plural forms string into an AST, returning a function which interprets a count value to its plural form. There is no caching for this function, and it is invoked on every call todcnpgettext
for the default locale. The first implementation here simply memoizedJed.PF.compile
, which improved performance significantly and had the advantage of likely caching just a single value function result. The main downside is that we'd be modifying the module directly, so any other dependents would inherit the same behavior. The approach here is isolated to thei18n
module and is more performant, at the expense of higher memory cost of caching the result of each distinct translation call.