Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sync workflow only when main branch is updated #78

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 25, 2021

Description

This PR prevents the sync workflow from running except when main branch has changed. This means that the workflow will not run for other branches or PRs.

Technical details

See the discussion: WordPress/openverse-frontend#268 (comment)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 25, 2021 13:13
@dhruvkb dhruvkb added 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Sep 25, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@dhruvkb dhruvkb merged commit d3707ab into main Sep 28, 2021
@dhruvkb dhruvkb deleted the sync_main branch September 28, 2021 03:55
dhruvkb pushed a commit that referenced this pull request Feb 20, 2023
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
Move the common package up a level to simplify imports and testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants