-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the moderation decision model #3989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far, but I have two significant requests for changes:
- Lets use full-names for the decision reason slugs, unless there's a really good reason not to that I am not seeing. If that is the case, then please document the reason in code.
- We need to stick to standard Django tools for URL building, and should use
request.build_absolute_uri
for consistent and correct behaviour for each requester.
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
e32bfa0
to
49520c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model and associated changes all look good! I was able to run the app successfully locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one suggestion to leave out the is_moderated
property until we need it (or maybe even just in preference of using not is_pending
as a clearer and "only one obvious way").
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced. |
Fixes
Fixes #3636 by @sarayourfriend
Description
This PR
decision
field on the report modelsstatus
field on the report models to use the decision modeldecision
fieldstatus
column from content report tables #3642AbstractMediaReport
model (and update tests)Note
The model uses some different names to match the naming scheme used by other API models. These are small, positive changes and should not block merge.
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin