-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft migration to Nuxt 3 - not ready yet #3571
Conversation
73fba53
to
e09dbf3
Compare
This is my least favourite decision from Nuxt 3 (along with implicit imports, which the generated tsconfig also is meant to support), but I need to look more into how people are dealing with this in a monorepo setting. It's baffling to me that this works for people, it's so much dependency on the build to generate a valid TypeScript configuration, which feels backwards to me in every single way. I'll review this PR today and see if I can understand the issue inside the playright container. Off the top of my head, I'm wondering if I'll even run into this because I'm not running an ARM CPU. Just based on the name of the package that can't be loaded, my first hunch is that it's something related to arm64 vs amd64 Docker (but who knows!) |
@obulat Have you tried this, by any chance? vitejs/vite#15167 |
Okay WOW the build is SO FAST 🤯 |
Just copying out the warnings I'm seeing locally in case they aren't known yet:
|
I get a totally different issue running Playwright locally:
Looking into it now. |
Okay, I've got playwright running locally (tests fail though). Took a lot of fiddling and debugging stuff. There are a whole lot of tiny little differences and details to how Nuxt 3 and Nitro work that took quite some time to sort through. Pushed changes for that to this branch. Next up, I'm going to get ESLint working 🙂 |
d6f6d2e
to
cc741e1
Compare
ESLint configuration is fixed in the latest commit too now 🙂 |
b66b20d
to
cd29b1e
Compare
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
d185855
to
cbe4eb1
Compare
Playwright failure test results: https://github.com/WordPress/openverse/actions/runs/7422288778 It looks like some of the Playwright tests failed. You can download the trace output and image diffs for the failed tests under the "Artifacts" section in the above page. You can read the docs on how to use this artifact. If the test is flaky, follow the flaky test triage procedure. |
Closing this in lieu of #3646 |
Fixes
Fixes #[issue number] by @[issue author]
Description
This is still WIP. You can run the app locally using
jf dev:only
. Note: don't runjf dev
because that would download the locales which have some illegal keys, i.e.{creator-name}
instead of{creatorName}
which are not caught and converted for some reason. These keys break the build.It mostly works. Things that don't:
The mobile content switcher modal (the menu button) causes a warning about using runtime directives on a non-element, and is slow.
Testing does not work. The Playwright build fails with:
I tried to set up the
nuxt/test-utils
that use Vitest under the hood, but couldn't get the module mocking and wrapper components to work. There is also an error wheni18n-t
component is not recognized, so the tests for components that contain it (most do!) fail.@sarayourfriend, do you have any idea on how we could fix the Playwright build?
By the way, I replaced the
tsconfig.base
with the tsconfig that's generated by Nuxt because it generates some paths for the#app
and#imports
. If we extend the base config using another tsconfig withpaths
property, those get overwritten.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin