Use the GitHub API to get the label's node ID #3483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@sarayourfriend was right in this review, I should've used an API to get the label IDs instead of hardcoding them. Using hardcoded labels would mean that the infrastructure repo labelling would not work as those IDs were from the monorepo and only present on the monorepo.
This PR is not critical though as labelling works on the monorepo for now and the infra repo is private and only accessible to maintainers who can label their own PRs till this is merged and pushed.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin