Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the GitHub API to get the label's node ID #3483

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 7, 2023

Description

@sarayourfriend was right in this review, I should've used an API to get the label IDs instead of hardcoding them. Using hardcoded labels would mean that the infrastructure repo labelling would not work as those IDs were from the monorepo and only present on the monorepo.

This PR is not critical though as labelling works on the monorepo for now and the infra repo is private and only accessible to maintainers who can label their own PRs till this is merged and pushed.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Dec 7, 2023
@dhruvkb dhruvkb requested a review from a team as a code owner December 7, 2023 10:14
@dhruvkb dhruvkb requested review from fcoveram and stacimc December 7, 2023 10:14
@fcoveram fcoveram removed their request for review December 7, 2023 10:23
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting problem, that problem hadn't crossed my mind. Thinking of the API limits issue. I wonder if it's possible to consolidate any queries? I haven't looked at the workflow at all to see for myself, but I can help look later if you'd like. Maybe GraphQL Fragments would be viable for it?

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 7, 2023

Yes @sarayourfriend I would appreciate any audit into where we could avoid or consolidate API calls. GraphQL might not be 100% helpful because GitHub calculates GraphQL rate limits differently rather than number of calls which applies to REST.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have 2 hard-coded options and select one of them based on the repository where this runs to prevent extra GitHub API calls.

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 8, 2023

That's such a simple idea @obulat, and so elegant as well. We will definitely do that once we start getting rate-limited by GitHub. Till then the more flexible it is, the better 👍!

@dhruvkb dhruvkb merged commit 6dbd3d1 into main Dec 8, 2023
65 checks passed
@dhruvkb dhruvkb deleted the fix_label_infra branch December 8, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants