Set API Dockerfile run to production config #2808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2785 by @sarayourfriend
Description
Switches the API image to have
gunicorn
as the run command, rather than the development command. See the issue for rationale. The development run command is now just in the docker-compose file, which is the primary place for development configuration.Testing Instructions
Run
just down && just build web && just api/up
and confirm that the API is accessible. Remember tojust api/init
if you're working on a fresh clone.To test the production configuration, comment out the
command
on theweb
service of docker-compose.yml and confirm that it's still accessible. Note that static files will not work in this configuration because in production we rely on Nginx to serve them and we do not have that configured locally! As long as you can access the API and see unstyled DRF pages when making requests, things should be working as expected.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin