Fix text wrapping in watermarked images

[zackkrida]

Fixes

Fixes #2466 by @zackkrida

Description

Fixes the watermark endpoint's ability to wrap text to multiple lines.

Testing Instructions

Make sure tests pass. Also, you could add this test to main and verify that it fails there:

diff --git a/api/test/unit/utils/test_watermark.py b/api/test/unit/utils/test_watermark.py
index f9a8c994d..1fb5814a3 100644
--- a/api/test/unit/utils/test_watermark.py
+++ b/api/test/unit/utils/test_watermark.py
@@ -51,3 +51,17 @@ def test_sends_UA_header(requests):
     assert len(requests.requests) > 0
     for r in requests.requests:
         assert r.headers == HEADERS
+
+def test_long_title_returns_correctly(requests):
+    # Make the title 400 chars long
+    _MOCK_IMAGE_INFO_LONG_TITLE = dict(_MOCK_IMAGE_INFO)
+    _MOCK_IMAGE_INFO_LONG_TITLE["title"] = "a" * 400
+
+    watermark("http://example.com/", _MOCK_IMAGE_INFO_LONG_TITLE)
+
+    assert len(requests.requests) > 0
+    for r in requests.requests:
+        assert r.headers == HEADERS
+
+    # Assert that the content of the response is the mock image bytes
+    assert requests.requests[0].response.content == _MOCK_IMAGE_BYTES

on macos copy the diff here and pbpaste | git apply. Otherwise save it to a file and cat diff.patch | git apply.

Then, run the test file with just api/test test/unit/utils/test_watermark.py

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

This is so weird! I would never think that integer division with float would return a float.
Great find!

[zackkrida]

Yup, who knew?

>>> 10.2 // 10
1.0

[stacimc]

LGTM 👍

[dhruvkb]

The fact that // calculates the integer quotient but in a float type is just plain silly.