Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused files from /frontend #2461

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Remove unused files from /frontend #2461

merged 1 commit into from
Jul 3, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 21, 2023

Description

This PR removes the unused images and components:

  • browser images that were used on the extension page
  • VImageCarousel used on the previous version of the homepage
  • external-sources page: its contents were moved to the about page.

Testing Instructions

The CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend skip-changelog labels Jun 21, 2023
@obulat obulat requested a review from a team as a code owner June 21, 2023 08:13
@obulat obulat requested review from AetherUnbound and dhruvkb June 21, 2023 08:13
@obulat obulat marked this pull request as draft June 21, 2023 08:14
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

Size Change: -14.7 kB (-2%)

Total Size: 829 kB

Filename Size Change
./frontend/.nuxt/dist/client/234.js 0 B -272 B (removed) 🏆
./frontend/.nuxt/dist/client/234.modern.js 0 B -277 B (removed) 🏆
./frontend/.nuxt/dist/client/235.js 0 B -1.85 kB (removed) 🏆
./frontend/.nuxt/dist/client/app.js 122 kB -949 B (-1%)
./frontend/.nuxt/dist/client/app.modern.js 113 kB -964 B (-1%)
./frontend/.nuxt/dist/client/components/v-image-carousel.js 0 B -4.7 kB (removed) 🏆
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 0 B -4.66 kB (removed) 🏆
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.1 kB -118 B (-1%)
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.1 kB -121 B (-1%)
./frontend/.nuxt/dist/client/pages/external-sources.js 0 B -1.55 kB (removed) 🏆
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 0 B -1.55 kB (removed) 🏆
./frontend/.nuxt/dist/client/runtime.js 2.69 kB -23 B (-1%)
./frontend/.nuxt/dist/client/runtime.modern.js 2.69 kB -24 B (-1%)
./frontend/.nuxt/dist/client/232.js 272 B +272 B (new file) 🆕
./frontend/.nuxt/dist/client/232.modern.js 276 B +276 B (new file) 🆕
./frontend/.nuxt/dist/client/233.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/commons/app.js 90.2 kB -2 B (0%)
./frontend/.nuxt/dist/client/commons/app.modern.js 80.8 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.js 5.18 kB +1 B (0%)
./frontend/.nuxt/dist/client/commons/components/v-search-grid/pages/search.modern.js 5.62 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/loading-icon.js 728 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 732 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.07 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.92 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-cell.js 572 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 572 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 1.76 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.74 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 958 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 962 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.32 kB -4 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.27 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 635 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.25 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.05 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 524 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 491 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.25 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 792 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 799 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.6 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.56 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.89 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.87 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 896 B +2 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 896 B 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.57 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.89 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.88 kB +6 B (0%)
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.77 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.74 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.81 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.41 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.25 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.13 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 642 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 647 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.14 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.04 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 933 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 940 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.93 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.91 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 994 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-no-results.js 855 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 856 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 976 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.65 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.65 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 892 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 6.89 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 6.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 620 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-server-timeout.js 299 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 302 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 914 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.06 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 6.32 kB -3 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 6.12 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 7.24 kB -3 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 6.99 kB +3 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.js 5 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.74 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/index.js 6.98 kB +4 B (0%)
./frontend/.nuxt/dist/client/pages/index.modern.js 6.91 kB +7 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.3 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.3 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.24 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.24 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.59 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 2.25 kB 0 B
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.js 3.79 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.66 kB -4 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.js 546 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 547 B -2 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.js 442 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 448 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/sources.js 1.51 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.js 65.4 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.modern.js 64.8 kB 0 B

compressed-size-action

@obulat obulat force-pushed the remove/unused_components branch from 245255e to 3de9a2b Compare July 3, 2023 03:00
@obulat obulat force-pushed the remove/unused_components branch from 3de9a2b to 2473882 Compare July 3, 2023 09:07
@obulat obulat marked this pull request as ready for review July 3, 2023 09:07
dhruvkb
dhruvkb approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for identifying.

zackkrida
zackkrida approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@obulat obulat merged commit f43a768 into main Jul 3, 2023
@obulat obulat deleted the remove/unused_components branch July 3, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed skip-changelog 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @zackkrida @dhruvkb