Add VIEW_EXTERNAL_SOURCES event #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧱 stack: frontend
|
Size Change: +440 B (0%) Total Size: 830 kB
ℹ️ View Unchanged
|
zackkrida
added
🟧 priority: high
zackkrida
requested review from
obulat and
dhruvkb
and removed request for
AetherUnbound and
sarayourfriend
zackkrida
commented
Jul 2, 2023
dhruvkb
approved these changes
Jul 2, 2023
| @@ -139,6 +146,11 @@ export default defineComponent({ | |||
|
|
|||
| const isVisible = ref(false) | |||
|
|
|||
| // Use the `_searchType` from mediaStore because it falls back to ALL_MEDIA | |||
There was a problem hiding this comment.
The comment says something different from what's happening. searhType is being used from the searchStore on L169.
sarayourfriend
previously requested changes
Jul 3, 2023
obulat
requested changes
Jul 3, 2023
There was a problem hiding this comment.
After adding @sarayourfriend's comments, we can add VExternalSources folder to tsconfig. The types will already be correct, no other changes will be necessary:
"src/components/VExternalSearch/**.vue",
|
@obulat I tried adding the file to the tsconfig, but curiously the whole Vue component is underlined red with the following type error:
|
|
The fix to the type signature was made and the irrelevant comment was removed. |
Co-authored-by: Olga Bulat <obulat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1075 by @dhruvkb
Description
Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin