Analytics Event: LOAD_MORE_RESULTS
#2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
|
Size Change: +242 B (0%) Total Size: 843 kB
ℹ️ View Unchanged
|
|
I just remembered @obulat added some Playwright analytics testing previously: I'll try updating that implementation to use this new code, which would be a good way to validate its usefulness! |
This was referenced Jun 19, 2023
Closed
obulat
reviewed
Jun 20, 2023
Co-authored-by: Olga Bulat <obulat@gmail.com>
obulat
reviewed
Jun 20, 2023
Can you clarify how this would work? Plausible only allows querying by a single custom prop at a time (see the note here). We could work around that by combining the media type and query into a single prop. The media type is critical information for all queries anyway. |
I've added the |
|
@zackkrida According to @obulat's comment, I suppose this needs to be rebased now that #2454 is merged before it can be reviewed? |
|
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @AetherUnbound Excluding weekend1 days, this PR was ready for review 6 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
|
Drafting to implement the |
zackkrida
changed the title
LOAD_MORE_RESULTS analytics event + Playwright helpers for analytics eventsLOAD_MORE_RESULTS
|
@AetherUnbound and @obulat I've added the currentPage logic and this PR is ready for review. |
AetherUnbound
approved these changes
Jun 30, 2023
sarayourfriend
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1074 by @dhruvkb
Fixes #1992 by @sarayourfriend
Description
This PR adds a
LOAD_MORE_RESULTSanalytics event to the load more button.Crucially, I did not include the original page number property in the event payload, as it requires major additions to the media and search stores.Thanks, @obulat.Testing Instructions
CI should pass, and then review the code. Let me know what you think of this API surface! Should we even be testing analytics events in e2e tests? I suspect it could be a nice additional assurance. If so we might want to add it in other places, like for pageviews and other custom events. That gets into larger issues about our frontend test consistency and coverage though.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin