Add APPLY_FILTER analytics event #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
obulat
force-pushed
the
add/APPLY_FILTER_event
branch
from
dbbc8d1 to
830c504
Compare
|
Size Change: +96 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
If we want to debounce this it should be added here, otherwise there will be a time span where the event happens far more often than otherwise, making it harder to understand the rate of the event being sent per session.
However, if we debounced it, what would we send? In debouncing, would we still send individual events per filter value changed? In that case, don't bother debouncing. We only debounce the filter changes being sent to search to prevent unnecessary search requests. If we debounced and combine all the updated filters into a single event, that might be worth it, but would slightly change the way this event would be queried. It would probably warrant a slightly different API to make it easier to tell both what filters are applied and how often a particular filter is applied then unapplied (which might imply the filter isn't as useful as others).
obulat
force-pushed
the
add/APPLY_FILTER_event
branch
from
830c504 to
5e3757f
Compare
|
Olga and I chatted a bit yesterday and we concluded we should try without debouncing these. The only reason to debounce would be perceived performance for the user or performance of the |
zackkrida
requested changes
Jun 20, 2023
There was a problem hiding this comment.
This works perfectly. However, I think we're missing a property for if the filter is being enabled or disabled in the payload. This was the original intention of the "value" property, but the way it's implemented here makes sense to me so I think we just need an additional property.
obulat
force-pushed
the
add/APPLY_FILTER_event
branch
from
5e3757f to
9ba0f8c
Compare
zackkrida
approved these changes
Jun 21, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1070 by @dhruvkb
Description
This PR adds
APPLY_FILTERevent sent when the user selects a filter.We might want to debounce it, I'm not sure if I should add it here?
Some unrelated changes were also added to clean up the unused ref, and use
storeToRefspinia helper to reduce the number of computeds used in the file.Testing Instructions
Try clicking on the filters (both in the modal on mobile screen, and the sidebar on the desktop). You should see the event logged in the console, and tracked in Plausible at 0.0.0.0:50288 (if you run
just frontend/upandjust frontend/initas described in https://docs.openverse.org/frontend/guides/analytics.html).Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin