-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TOGGLE_FILTER_SIDEBAR analytics event #2405
Conversation
Size Change: +121 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any new tests which should be added for this change?
Drafting while updates are made. |
…ress/openverse into fix-#1088-add-TOGGLE_FILTERS-event
@obulat and @AetherUnbound this is ready for review. The type signature of the event was fixed and I've added a unit test. |
…e of filter sidebar
@obulat suggestions made; thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, and all works well 🚀
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @AetherUnbound Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and verified locally that it fires off appropriately!
Fixes
Fixes #1088 by @dhruvkb
Description
Adds an event for toggling the desktop filter sidebar. I renamed the event to
TOGGLE_FILTER_SIDEBAR
to better accurately reflect it's behavior. As the original author of the proposal, my intention of this event was to track the desktop sidebar specifically as it's a piece of potentially persistent UI a user may choose to keep open at all times.Testing Instructions
Toggle the filter sidebar on different media type search views. Observe that the state of the filter sidebar is accurately reported in the event in the logs.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin