Analytics: Add SELECT_SEARCH_RESULT event #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
|
Size Change: +1.57 kB (0%) Total Size: 847 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
add/SELECT_SEARCH_RESULT_event
branch
from
33f6467 to
b34c7f6
Compare
AetherUnbound
approved these changes
Jun 15, 2023
| props: { | ||
| image, | ||
| searchTerm: "cat", | ||
| aspectRatio: "square", |
There was a problem hiding this comment.
Is this prop necessary for this test?
There was a problem hiding this comment.
square is the default for aspectRatio, so you're right, we can remove it.
|
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @dhruvkb Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
sarayourfriend
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
LGTM! Tested perfectly locally in all the places 🎉
Something to note is that homepage images do not have this event, so the total number of works "navigated to" on the site from another page of the site won't necessarily be equal to the number of SELECT_SEARCH_RESULT events. I doubt this will have any bearing on anything, but I could easily see some discrepancy between these causing us to scratch our heads in the future 😂
obulat
commented
Jun 16, 2023
frontend/test/unit/specs/components/VSearchResultsGrid/v-image-cell.spec.js
Outdated
Show resolved
Hide resolved
Actually, we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1079 by @dhruvkb
Description
This PR sends analytics events when the user selects one of the search results on the search page or one of the related media items on the single result page.
Testing Instructions
Try selecting results on the search pages (all content/image/audio) or the related items on the single result page. You should see the events in Plausible UI or in the console
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin