-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project thread reminders #2251
Project thread reminders #2251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Glad actions/github-script
simplified things so much 👍 In the future if we want the niceties of having an import with type hints in our editors, we can always install the packages as development dependencies (or their @type
package) and apply type information using JSDoc on the exported function.
@sarayourfriend I made small updates here to:
I think these are minimal enough that your review should remain valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- double-checked the test output and looks great :)
Fixes
Fixes #2250 by @zackkrida
Description
Adds a run-daily GitHub action which checks all project threads for comments in the last 14 days. If a thread hasn't been commented on, a comment is left on the issue asking the author to write an update. The comment is formatted like this:
Rendered:
Hi {recipient}, this project has not received an update comment in 14 days. Please leave an update comment as soon as you can. See the documentation on project updates for more information.
In markdown:
Testing Instructions
This can be easily tested via a manual workflow run. Be sure to leave theDry run
box checked otherwise the script will leave comments on several project threads 😄This testing mechanism has been removed. See the results below though!
You can see my latest run and it's results here.
The threads identified to update by the script, as of today (2023-05-31), are:
Which should be correct.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin