Analytics event: SUBMIT_SEARCH
#2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
💻 aspect: code
|
Size Change: +179 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
add/SUBMIT_SEARCH_event
branch
from
830ddbd to
f493115
Compare
AetherUnbound
approved these changes
May 18, 2023
obulat
force-pushed
the
add/SUBMIT_SEARCH_event
branch
from
5f78d52 to
3d1fc03
Compare
dhruvkb
reviewed
May 18, 2023
Not style changes, but refactoring of the search button. The old search button used to have logic to decide whether to show an icon or a text label, and there were two different components for StandaloneSearchBar and the SearchBar - I combined them in this PR. Edited to add: @dhruvkb , I've extracted the style changes to a separate PR and rebased this on it. |
obulat
force-pushed
the
add/SUBMIT_SEARCH_event
branch
4 times, most recently
from
affda65 to
9106907
Compare
obulat
force-pushed
the
update/search_button
branch
5 times, most recently
from
9dd91a3 to
27167a7
Compare
obulat
force-pushed
the
add/SUBMIT_SEARCH_event
branch
from
9106907 to
23377ba
Compare
obulat
force-pushed
the
add/SUBMIT_SEARCH_event
branch
from
23377ba to
b2292ed
Compare
|
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @dhruvkb Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
dhruvkb
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1068 by @obulat
Description
This PR adds a
SUBMIT_SEARCHanalytics event that is fired when the search is submitted from the homepage, the search bar in the search page header, and the 404 page.This PR also simplifies theEdit: Extracted to standalone PR #2148.VSearchButtoncomponent removing the version that used a text label, and using it in both the SearchBar and the StandaloneSearchBar (which is used on 404 and home pages, and does not remove the search text when the server-rendered page is hydrated).The unused input sizes (standalone/large) are also removed.
Home page directly imports the child components instead of lazy-loading them, because they are always loaded anyways.
Testing Instructions
Set up analytics (
just frontend/up,just frontend/init) and run the app (just frontend/run dev).Open the app (localhost:8443) and the analytics server (http://0.0.0.0:50288/).
Try executing searches from all three places in the description, and see that the Custom events section1 shows the events correctly.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin
Footnotes
https://docs.openverse.org/frontend/guides/analytics.html#custom-events ↩