Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics event: GET_MEDIA #1180

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Analytics event: GET_MEDIA #1180

merged 4 commits into from
Apr 19, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 12, 2023 •
edited
Loading

Fixes

Fixes #1080 by @dhruvkb

Description

This PR adds the GET_MEDIA analytics event that is fired when the user clicks the "Get this image" or "Get this audio" CTA button on the single result page.

Testing Instructions

Set up the analytics events using just frontend/up and just frontend/init.
Run the app using just frontend/dev.
Click on the "Get this image" or "Get this audio"

Screenshot 2023-04-12 at 10 56 40 AM

Screenshot 2023-04-12 at 10 56 56 AM

Check that the event is shown in Plausible: http://0.0.0.0:50288/localhost?goal=GET_MEDIA

Screenshot 2023-04-12 at 10 56 06 AM

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner April 12, 2023 07:59
@obulat obulat requested review from zackkrida and dhruvkb April 12, 2023 07:59
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Apr 12, 2023
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Apr 12, 2023
@github-actions
Copy link

github-actions bot commented Apr 12, 2023 •
edited
Loading

Size Change: +3.53 kB (0%)

Total Size: 848 kB

Filename Size Change
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.6 kB +450 B (+9%) 🔍
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.54 kB +432 B (+8%) 🔍
./frontend/.nuxt/dist/client/components/v-full-layout.js 2.13 kB +675 B (+46%) 🚨
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 2.1 kB +644 B (+44%) 🚨
./frontend/.nuxt/dist/client/components/v-home-gallery.js 5.27 kB +36 B (+1%)
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 5.25 kB +28 B (+1%)
./frontend/.nuxt/dist/client/pages/image/_id/index.js 6.56 kB +616 B (+10%) ⚠️
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.74 kB +585 B (+11%) ⚠️
./frontend/.nuxt/dist/client/pages/index.js 7.33 kB +18 B (0%)
./frontend/.nuxt/dist/client/pages/index.modern.js 7.28 kB +42 B (+1%)
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/234.js 272 B 0 B
./frontend/.nuxt/dist/client/234.modern.js 277 B 0 B
./frontend/.nuxt/dist/client/235.js 1.85 kB 0 B
./frontend/.nuxt/dist/client/app.js 127 kB -2 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 118 kB -2 B (0%)
./frontend/.nuxt/dist/client/commons/app.js 90.3 kB -8 B (0%)
./frontend/.nuxt/dist/client/commons/app.modern.js 78.5 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/loading-icon.js 751 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 758 B +1 B (0%)
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 5.64 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.49 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.js 393 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 397 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 2.48 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.78 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.02 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 543 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 548 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 689 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 694 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.28 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 524 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 528 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 783 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 787 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.78 kB +5 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.19 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1.01 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 10 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 753 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 759 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.69 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.69 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.86 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.85 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.js 844 B 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 846 B 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.73 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.73 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.71 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.59 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.59 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.js 2.09 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.41 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.js 2.67 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.55 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 529 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 810 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 708 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 829 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 836 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.61 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.62 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 757 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 755 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.54 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.51 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.26 kB -3 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.27 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-related-images.js 3.25 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.12 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B +1 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.67 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.68 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-scroll-button.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 829 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.68 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.61 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.js 599 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 605 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 300 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 912 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.16 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.17 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-sources-table.js 15.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15.2 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 5.55 kB -5 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.85 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB -2 B (0%)
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.56 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.js 1.27 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.26 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 2.2 kB 0 B
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.js 3.61 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.52 kB 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 2.85 kB 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.74 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.js 443 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 447 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 270 B -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/sources.js 1.52 kB +3 B (0%)
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/runtime.js 2.72 kB 0 B
./frontend/.nuxt/dist/client/runtime.modern.js 2.72 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.js 64.1 kB -1 B (0%)
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.3 kB 0 B

compressed-size-action

@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/1180

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

dhruvkb
dhruvkb approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have a few nits but nothing blocking.

frontend/src/types/analytics.ts Show resolved Hide resolved
frontend/src/types/analytics.ts Outdated Show resolved Hide resolved
@obulat obulat force-pushed the add/GET_MEDIA_event branch from 1524cb8 to d9f2f05 Compare April 12, 2023 14:33
@obulat obulat force-pushed the add/GET_MEDIA_event branch from d9f2f05 to 5e141ce Compare April 16, 2023 05:40
@obulat obulat requested review from a team as code owners April 16, 2023 05:40
@github-actions
Copy link

This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced.

@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Apr 16, 2023
@obulat obulat changed the base branch from main_old to main April 16, 2023 05:41
@obulat obulat removed request for a team April 16, 2023 05:41
@obulat obulat removed 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Apr 16, 2023
zackkrida
zackkrida approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, LGTM.

@obulat obulat merged commit 16df1af into main Apr 19, 2023
@obulat obulat deleted the add/GET_MEDIA_event branch April 19, 2023 14:03
@obulat obulat mentioned this pull request Apr 27, 2023
Merged
@dhruvkb dhruvkb mentioned this pull request Jun 16, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics event: GET_MEDIA
3 participants
@obulat @zackkrida @dhruvkb