-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics event: RIGHT_CLICK_IMAGE #1156
Conversation
This is a great start, @CouldBeFree ! This event is meant to track when the users right-click the single result page (for example, https://openverse.org/image/f9384235-b72e-4f1e-9b05-e1b116262a29?q=Cat) image, not the homepage images. The relwvant component is |
@obulat thanks for your point. |
* Project Proposal: Search Relevancy Sandbox * data refresh server -> ingestion server * Clarifications about size and which index is referenced * Clarify motivation for proportional index and implementation plans * Move & re-title document * Add clarification from @zackkrida and @krysal * Add an index file
* Publish changelog for api-2023.04.12.23.29.59 * Changelog/api 2023.04.12.23.29.59 manual cleanup (WordPress#1186) * Remove non-api commits from the changelog * Update documentation/changelogs/api/2023.04.12.23.29.59.md --------- Co-authored-by: AetherUnbound <AetherUnbound@users.noreply.github.com> Co-authored-by: Olga Bulat <obulat@gmail.com>
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @CouldBeFree, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some changes, nice work so far!
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Zack Krida <zackkrida@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some code suggestions, and am approving this PR. We will also need to add a unit test for it in a separate PR. Thank you for your contribution, @CouldBeFree !
Fixes
Fixes #1086 by @dhruvkb
Description
Events
typeAdds new event listener forVLink
component in theVHomeGallery.vue
for tracking new event typeChecklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin