Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics event: RIGHT_CLICK_IMAGE #1156

Merged
merged 18 commits into from
Jun 6, 2023

Conversation

CouldBeFree
Copy link
Contributor

@CouldBeFree CouldBeFree commented Apr 10, 2023

Fixes

Fixes #1086 by @dhruvkb

Description

  • Adds new event type to the Events type
  • Adds new event listener for VLink component in the VHomeGallery.vue for tracking new event type

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@CouldBeFree CouldBeFree requested a review from a team as a code owner April 10, 2023 07:39
@CouldBeFree CouldBeFree requested review from zackkrida and obulat April 10, 2023 07:39
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Apr 10, 2023
@obulat
Copy link
Contributor

obulat commented Apr 10, 2023

This is a great start, @CouldBeFree !

This event is meant to track when the users right-click the single result page (for example, https://openverse.org/image/f9384235-b72e-4f1e-9b05-e1b116262a29?q=Cat) image, not the homepage images.

The relwvant component is frontend/src/pages/image/_id/index.vue

@CouldBeFree
Copy link
Contributor Author

@obulat thanks for your point.
I will implement updates

@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 10, 2023
pnpm-lock.yaml Outdated Show resolved Hide resolved
Oleksandr.Zoria and others added 4 commits April 14, 2023 14:58
* Project Proposal: Search Relevancy Sandbox

* data refresh server -> ingestion server

* Clarifications about size and which index is referenced

* Clarify motivation for proportional index and implementation plans

* Move & re-title document

* Add clarification from @zackkrida and @krysal

* Add an index file
* Publish changelog for api-2023.04.12.23.29.59

* Changelog/api 2023.04.12.23.29.59 manual cleanup (WordPress#1186)

* Remove non-api commits from the changelog

* Update documentation/changelogs/api/2023.04.12.23.29.59.md

---------

Co-authored-by: AetherUnbound <AetherUnbound@users.noreply.github.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>
@obulat obulat changed the base branch from main_old to main April 21, 2023 15:28
@obulat obulat requested a review from a team as a code owner April 21, 2023 15:28
@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@CouldBeFree, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some changes, nice work so far!

frontend/src/pages/image/_id/index.vue Outdated Show resolved Hide resolved
frontend/src/pages/image/_id/index.vue Outdated Show resolved Hide resolved
frontend/src/pages/image/_id/index.vue Outdated Show resolved Hide resolved
@obulat obulat changed the title extended event type by adding right click image event Analytics event: RIGHT_CLICK_IMAGE May 2, 2023
@obulat obulat mentioned this pull request May 3, 2023
26 tasks
Co-authored-by: Zack Krida <zackkrida@pm.me>
@WordPress WordPress deleted a comment from zackkrida Jun 6, 2023
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some code suggestions, and am approving this PR. We will also need to add a unit test for it in a separate PR. Thank you for your contribution, @CouldBeFree !

@obulat obulat requested a review from zackkrida June 6, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Analytics event: RIGHT_CLICK_IMAGE
5 participants