Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit request argument parsing #741

Open
1 task
AetherUnbound opened this issue Dec 14, 2021 · 3 comments
Open
1 task

Audit request argument parsing #741

AetherUnbound opened this issue Dec 14, 2021 · 3 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@AetherUnbound
Copy link
Collaborator

Description

It came about while discussing WordPress/openverse-api#398 that we should do an audit of all request argument processing (e.g. request.query_params usage) to make sure that we don't have other possible points of failure where users (or the frontend!) might submit inappropriate values.

Alternatives

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Dec 14, 2021
@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community labels Feb 2, 2022
@sarayourfriend sarayourfriend mentioned this issue Feb 6, 2022
Closed
@Vidush22
Copy link

Vidush22 commented Sep 8, 2022

@AetherUnbound ,
I want to work on this matter. Kindly consider my request.

@dhruvkb
Copy link
Member

dhruvkb commented Sep 10, 2022

@Vidush22 sure, go ahead. Feel free to ping here on post in the #openverse channel in the Making WordPress Slack workspace if you need any help.

@obulat obulat transferred this issue from WordPress/openverse-api Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat added 🧱 stack: api Related to the Django API and removed 🧱 stack: backend labels Mar 20, 2023
@tammytdo
Copy link
Contributor

tammytdo commented Mar 20, 2023 •
edited
Loading

Hi, I'd like to work on this. @sarayourfriend

dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@stacimc
Refactor Jamendo to use the ProviderDataIngester (#741)
db47359 
* Refactor Jamendo to use the ProviderDataIngester

* Remove unused test resources

* Use constants for media type

* Remove logs, parametrize tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AetherUnbound @obulat @dhruvkb @tammytdo @Vidush22