Add Slack functionality inside logger (#2395)

* Add Slack functionality inside logger #698

* Add stacklevel=2 in the log calls

* Resolve confict

* Add stacklevel=2 in the log calls

* Add stacklevel=3 in the status() method
Add stacklevel as an argument of the methods verbose(), info() and 
error()

---------

Co-authored-by: fred <fred.gilles@free.fr>
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>

ingestion_server/ingestion_server/indexer.py

@@ -367,7 +367,6 @@ def point_alias(self, model_name: str, index_suffix: str, alias: str, **_):
             if not alias_stat.is_alias:
                 # Alias is an index, this is fatal.
                 message = f"There is an index named `{alias}`, cannot proceed."
-                log.error(message)
                 slack.error(message)
                 return
             elif alias_stat.is_alias and curr_index != dest_index:
@@ -386,7 +385,6 @@ def point_alias(self, model_name: str, index_suffix: str, alias: str, **_):
                     f"Migrated alias `{alias}` from index `{curr_index}` to "
                     f"index `{dest_index}` | _Next: delete old index_"
                 )
-                log.info(message)
                 slack.status(model_name, message)
             else:
                 # Alias is already mapped.
@@ -398,7 +396,6 @@ def point_alias(self, model_name: str, index_suffix: str, alias: str, **_):
             # Alias does not exist, create it.
             self.es.indices.put_alias(index=dest_index, name=alias)
             message = f"Created alias `{alias}` pointing to index `{dest_index}`."
-            log.info(message)
             slack.status(model_name, message)
 
         if self.progress is not None:
@@ -436,7 +433,6 @@ def delete_index(
                         f"Verify that the API does not use this alias and then use the "
                         f"`force_delete` parameter."
                     )
-                    log.error(message)
                     slack.error(message)
                     return
                 target = target_stat.alt_names
@@ -449,20 +445,17 @@ def delete_index(
                         f"Index `{target}` is associated with aliases "
                         f"{target_stat.alt_names}, cannot delete. Delete aliases first."
                     )
-                    log.error(message)
                     slack.error(message)
                     return
 
             self.es.indices.delete(index=target)
             message = f"Index `{target}` was deleted - data refresh complete! :tada:"
-            log.info(message)
             slack.status(model_name, message)
         else:
             # Cannot delete as target does not exist.
             if self.is_bad_request is not None:
                 self.is_bad_request.value = 1
             message = f"Target `{target}` does not exist and cannot be deleted."
-            log.info(message)
             slack.status(model_name, message)
 
         if self.progress is not None:

ingestion_server/ingestion_server/slack.py

@@ -60,15 +60,18 @@ def _message(text: str, summary: str = None, level: Level = Level.INFO) -> None:
         pass
 
 
-def verbose(text: str, summary: str = None) -> None:
+def verbose(text: str, summary: str = None, stacklevel: int = 2) -> None:
+    log.debug(text, stacklevel=stacklevel)
     _message(text, summary, level=Level.VERBOSE)
 
 
-def info(text: str, summary: str = None) -> None:
+def info(text: str, summary: str = None, stacklevel: int = 2) -> None:
+    log.info(text, stacklevel=stacklevel)
     _message(text, summary, level=Level.INFO)
 
 
-def error(text: str, summary: str = None) -> None:
+def error(text: str, summary: str = None, stacklevel: int = 2) -> None:
+    log.error(text, stacklevel=stacklevel)
     _message(text, summary, level=Level.ERROR)
 
 
@@ -79,4 +82,4 @@ def status(model: str, text: str) -> None:
     Model is required an all messages get prepended with the model.
     """
     text = f"`{model}`: {text}"
-    info(text, None)
+    info(text, None, stacklevel=3)

ingestion_server/ingestion_server/tasks.py

@@ -213,7 +213,6 @@ def promote():  # includes point alias
             func(model, **kwargs)  # Directly invoke indexer methods if no task function
     except Exception as err:
         exception_type = f"{err.__class__.__module__}.{err.__class__.__name__}"
-        logging.error(f"Error processing task `{action}` for `{model}`: {err}")
         slack.error(
             f":x_red: Error processing task `{action}` for `{model}` "
             f"(`{exception_type}`): \n"