Add changes from code review

WordPress · May 16, 2023 · 2960306 · 2960306
1 parent ac63a50
commit 2960306
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/frontend/src/components/VContentLink/VContentLink.vue b/frontend/src/components/VContentLink/VContentLink.vue
@@ -38,7 +38,6 @@ import useSearchType from "~/composables/use-search-type"
 
 import VIcon from "~/components/VIcon/VIcon.vue"
 import VLink from "~/components/VLink.vue"
-import VIcon from "~/components/VIcon/VIcon.vue"
 
 export default defineComponent({
   name: "VContentLink",

diff --git a/frontend/src/composables/use-component-name.ts b/frontend/src/composables/use-component-name.ts
@@ -6,5 +6,5 @@ import { getCurrentInstance } from "vue"
  */
 export const useComponentName = () => {
   const vm = getCurrentInstance()
-  return vm?.proxy.$options.name
+  return vm?.proxy.$options.name ?? "Unknown"
 }
diff --git a/frontend/src/composables/use-search-type.ts b/frontend/src/composables/use-search-type.ts
@@ -58,7 +58,7 @@ export default function useSearchType() {
     analytics.sendCustomEvent("CHANGE_CONTENT_TYPE", {
       previous: previousSearchType.value,
       next: searchType,
-      component: componentName ?? "Unknown",
+      component: componentName,
     })
     useSearchStore().setSearchType(searchType)
     previousSearchType.value = searchType