Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Make filter display vertically centered #91

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jul 13, 2021

Currently, the search filter tags are aligned to top vertically.
Screen Shot 2021-07-13 at 12 00 48 PM

However, in the design mockups they are center-aligned. This PR centers the filter tags vertically, and removes unnecessary spans from around the tag buttons:

Screen Shot 2021-07-13 at 11 56 12 AM

@obulat obulat requested a review from a team as a code owner July 13, 2021 09:09
@obulat obulat requested review from zackkrida and dhruvkb July 13, 2021 09:09
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the truly centered elements and the reduction of extras (<span>) are appreciated!

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better 👍

@obulat obulat merged commit 516087f into main Jul 14, 2021
@obulat obulat deleted the center_filter_display branch July 14, 2021 06:25
@zackkrida zackkrida added the 🛠 goal: fix Bug fix label Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants