Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove unused Google Analytics code #905

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Remove unused Google Analytics code #905

merged 1 commit into from
Feb 18, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Related to WordPress/openverse#634 by @sarayourfriend

Description

We don't use it. There's no reason to ship this code to our clients even if it's disabled.

Testing Instructions

Checkout this branch then run pnpm dev and test out navigating the website. Things should work! Try copying attribution and ensure there are no errors there as well, that was really the only place there was any GA code anyway.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 18, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner February 18, 2022 13:46
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zackkrida zackkrida requested review from krysal and dhruvkb and removed request for stacimc February 18, 2022 18:11
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also looks good. I tried to make sure there was no additional documentation or anything referencing Google Analytics and I don't see anything. Great to ship less code and offer users better privacy!

@sarayourfriend sarayourfriend merged commit 5a2de77 into main Feb 18, 2022
@sarayourfriend sarayourfriend deleted the remove/ga-stub branch February 18, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants