Rename NoticeBar and MigrationNotice components

[obulat]

Fixes

Fixes #495 by @obulat

Description

This PR renames the NoticBar and MigrationNotice components, adding the V prefix.

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

This one looks good. LGTM!

[zackkrida]

@obulat do you know if there's a way to see the translation banner locally? I'm not confident it isn't broken (unrelated to this PR) because I can't view it anywhere.

[obulat]

@obulat do you know if there's a way to see the translation banner locally? I'm not confident it isn't broken (unrelated to this PR) because I can't view it anywhere.

The easiest way to check locally would be to make this function in composable return false:

openverse-frontend/src/composables/use-i18n-sync.js

Lines 69 to 74 in 8e50891

	const shouldHideBanner = computed(() => {
	return (
	!showBanner.value ||
	bannerDismissedForLocales.value.includes(bannerLocale.code)
	)
	})

[zackkrida]

@obulat ah, I forgot about that, thanks! To ask a different way: why doesn't the bar show up on http://10.1.84.207:8443/ru, is that because the translation % comes in from the wp theme?

[obulat]

Yes, we need a setLocale message to show the translation banner. I guess we should change this

[sarayourfriend]

It's because of #784

Oh it also doesn't show locally otherwise anyway.

[zackkrida]

@sarayourfriend I think that's only part of it because it doesn't display on http://localhost:8443/ru/search locally either, which doesn't use the blank layout.

[sarayourfriend]

This LGTM. I also can't test the "normal" flow of the translation banner but the change is pretty low risk 🙂 Seems more like it would probably break on the .org theme side than anything.

Is that something we could change how it works using the path-based locale forwarding?