Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove unused store modules #863

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Remove unused store modules #863

merged 2 commits into from
Feb 14, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 14, 2022

Fixes

Fixes #862 by @obulat

Description

This PR removes the unused bug-report store module and the empty content-report store module.

Testing Instructions

Simply checking if the CI checks pass should be enough.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 14, 2022
@obulat obulat added this to the Switch from Vuex to Pinia milestone Feb 14, 2022
@obulat obulat requested a review from a team as a code owner February 14, 2022 17:16
@obulat obulat self-assigned this Feb 14, 2022
@obulat obulat requested review from zackkrida and dhruvkb February 14, 2022 17:16
@zackkrida
Copy link
Member

Does it make sense to remove the associated action and mutation type constants from these stores in this PR too?

@obulat
Copy link
Contributor Author

obulat commented Feb 14, 2022

Does it make sense to remove the associated action and mutation type constants from these stores in this PR too?

Definitely! Removed all unused action and mutation constants in the latest commit.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these sorts of PRs 🤩

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obulat obulat merged commit 771ebe7 into main Feb 14, 2022
@obulat obulat deleted the remove_unused_stores branch February 14, 2022 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused store modules
3 participants