-
Notifications
You must be signed in to change notification settings - Fork 63
Fix global layout issues #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good so far and seems to work fine on desktop. Getting weird message-less and stack-trace-less errors on mobile browser though, so will continue debugging to see if I can find the cause of that.
@sarayourfriend I did just push some cleanup, fyi. Small tweaks to mobile. |
Still getting the same mysterious error 😞 It prevents the JS on the page from running at all. |
Suuuper weird, I don't see anything that would cause that! |
It's the same on Firefox for Android and mobile Safari 🤔 I'll keep trying to debug. |
It appears to be an issue on |
@@ -1,7 +1,7 @@ | |||
<template> | |||
<VButton | |||
as="NuxtLink" | |||
to="/" | |||
:to="localePath('/')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the issue that Sara mentioned is unrelated to these changes this LGTM 👍
// Logic for displaying the filter sidebar and search results | ||
// as independently-scrolling sections. | ||
.main { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting the grid logic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout works perfectly!
overflow: hidden; | ||
} | ||
|
||
.main > * { | ||
.main > *:not(:empty) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding :not(:empty)
is such a great solution to all the teleports taking up grid areas when empty!
Fixes
Fixes #825
Description
This PR makes some cleanup to the main layout logic of every page:
min-width: 300px
from thehtml
element100%
width allowed the header to grow beyond the device width.xs
breakpoint. Time to make Openverse work on smart watches 😄In addition to fixing the layout bugs, this should put us in a better position while @panchovm works on additional header revisions.
Testing Instructions
View on an actual mobile device and by resizing your desktop browser window.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin