Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Unstuck searchStatus of search bar #833

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Unstuck searchStatus of search bar #833

merged 1 commit into from
Feb 9, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Feb 8, 2022

Fixes

Fixes #726 by @sarayourfriend

Description

Changing searchStatus to a computed property seems to solve the stuck text of the search bar.

Testing Instructions

Try searching different terms, change between media types (image, audio, all content) and observe if the search bar status changes correctly.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility labels Feb 8, 2022
@krysal krysal requested a review from obulat February 8, 2022 19:11
@krysal krysal requested a review from a team as a code owner February 8, 2022 19:11
@krysal krysal self-assigned this Feb 8, 2022
@krysal krysal requested a review from dhruvkb February 8, 2022 19:11
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's still not computed server-side for some reason (stays as "No results" until the client side JS starts up) but it's nice to see it actually working again 😁

This also definitely seems like the correct way to do this kind of thing... but I do wonder why watchEffect didn't work in this case (even though it is a circuitous way of doing it).

Oh well, just glad this fixes it anyway 🎉

@obulat
Copy link
Contributor

obulat commented Feb 9, 2022

Store changes do not trigger changes currently, I hope with Pinia this will get fixed.

@obulat
Copy link
Contributor

obulat commented Feb 9, 2022

Thank you for fixing this! I hope that after we switch to Pinia we can make it even better with store watchers that actually work

@krysal krysal merged commit 2b85c66 into main Feb 9, 2022
@krysal krysal deleted the fix/searchStatus branch February 9, 2022 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar result count always displays "no results"
3 participants