Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add underline to the "contribute a translation" link #826

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 8, 2022

Fixes

Fixes #731 by @obulat

Description

This PR adds an underline to the "contribute a translation" link in the banner for locales where translations are not finished. Together with the recent addition of pink color to all links, this makes the call-to-action link standout.
This PR also renames the components to add the V prefix, syncs the code style of the components, and makes the padding the same as the header padding.

Testing Instructions

The simplest way to see the translation banner is to set v-show="!shouldHideBanner" to the opposite: v-show="shouldHideBanner" (without the ! in the condition).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 8, 2022
@obulat obulat requested a review from a team as a code owner February 8, 2022 04:29
@obulat obulat self-assigned this Feb 8, 2022
@obulat obulat requested review from krysal and dhruvkb February 8, 2022 04:29
@obulat obulat changed the title Add underline to the "contribute a translation' link Add underline to the "contribute a translation" link Feb 8, 2022
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is solved with this. Thanks for standardizing the component names also!

I just wonder why I can´t see this change just visiting http://localhost:8443/nl-be/search/?q=vermillion for example? 🤔 Looks like another problem tho.

<template>
<div
class="wrapper px-4 md:px-7 py-2 md:flex md:items-center md:justify-between"
dir="ltr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this dir need to be always "ltr"? Doesn't this change for the Arabic language for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why this was added 🙈

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-02-08 at 22 38 56@2x

The link looks nice! I do want to confirm, like @krysal suggested, that we're confident the banner is displaying when it should.

@obulat obulat merged commit 9b1b36b into main Feb 9, 2022
@obulat obulat deleted the fix/translation_invite_link branch February 9, 2022 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation banner link doesn't look like a link
3 participants