Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Complete missing props #816

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Complete missing props #816

merged 2 commits into from
Feb 7, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Feb 4, 2022

Fixes

Fixes #786 by @zackkrida
Fixes #815 by @krysal

Description

This PR:

  • sets a default value for is-search-route property in the VLogoButton instead of requiring it every time and
  • sets the size of the VSearchBar in the error layout (404 page), fixing its style.

Testing Instructions

Follow steps in the linked issue, the warning errors should be gone.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [-] I added or updated tests for the changes I made (if applicable).
  • [-] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 4, 2022
@krysal krysal requested a review from a team as a code owner February 4, 2022 21:23
@krysal krysal self-assigned this Feb 4, 2022
@krysal krysal requested review from obulat and dhruvkb February 4, 2022 21:23
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these, @krysal ! Fewer warnings is always better.

@krysal krysal merged commit 0ef72cd into main Feb 7, 2022
@krysal krysal deleted the fix/missing_props branch February 7, 2022 13:25
@obulat obulat mentioned this pull request Feb 8, 2022
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple warnings for "Missing required prop" 404 Searchbar styles are broken
3 participants