Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Set default size of VAudioTrack with a computed property #814

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Feb 4, 2022

Fixes

Fixes #721 by @obulat

Description

This PR makes the default size for the boxed layout null instead of 'm' (preserved for all other layouts if not explicitly specified) with a computed property, this way we avoid the warning for an invalid prop and it still looks good in the All search results grid, as no fixed width is applied.

Testing Instructions

Follow instructions on the related issue and observe no more warnings are shown, maintaining the normal aspect of the all search results grid.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [-] I added or updated tests for the changes I made (if applicable).
  • [-] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This solves the warning error when needing the boxed layout without
a fixed width.
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 4, 2022
@krysal krysal requested a review from a team as a code owner February 4, 2022 20:14
@krysal krysal self-assigned this Feb 4, 2022
@krysal krysal requested review from zackkrida and dhruvkb February 4, 2022 20:14
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, it wasn't a trivial change.
It might be a good idea to add/edit comments, because the VBoxLayout has a comment at the top saying <!-- Should be wrapped by a fixed width parent -->, which probably isn't true anymore?

@zackkrida
Copy link
Member

<!-- Should be wrapped by a fixed width parent -->

Yes @obulat maybe something like "The width is determined by the parent element" or something would be clearer.

@krysal
Copy link
Member Author

krysal commented Feb 7, 2022

Thanks for noticing it, comment updated 📝

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just committed a small typo fix in the new comment 👍

@krysal krysal merged commit f5b7518 into main Feb 8, 2022
@krysal krysal deleted the fix/invalid_size_prop branch February 8, 2022 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All content grid is using an invalid size prop
3 participants