Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update color 'primary' to 'pink' after redesign #800

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Feb 4, 2022

Description

This PR updates the usages of the color primary to reference pink as it was planned to be done after the redesign launch.

Testing Instructions

  1. Check out the PR and run the Storybook & dev server.
  2. Search for the usages of color 'primary'.
  3. The usages should all be pink.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 4, 2022
@dhruvkb dhruvkb mentioned this pull request Feb 4, 2022
7 tasks
@dhruvkb dhruvkb marked this pull request as ready for review February 9, 2022 13:10
@dhruvkb dhruvkb requested a review from a team as a code owner February 9, 2022 13:10
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we would keep the primary key and switch everything that is using pink to use primary instead? 🤔 Otherwise future brand color changes will require a big find-and-replace job that could just be a one-line configuration change.

@dhruvkb
Copy link
Member Author

dhruvkb commented Feb 9, 2022

I suppose any changes to the brand in the future will involve more than color. Currently the usage of 'pink' is much more prevalent as compared to 'primary' which is just used in 2 places.

@sarayourfriend
Copy link
Contributor

Gotcha. I think we should re-evaluate this and think about how we use design tokens. You're right that a re-design would include more than color, but it could be "just color". Likewise, using a token like "primary" would make things like a dark-mode based on tokens easier to reason about instead of "pink" which would likely have a different color entirely under a dark-mode (maybe).

Either way, it's good to get rid of the two different names for the token, but I'd be interested in getting clearer decision making around whether to use generic token names or to use the color-names for the tokens.

@dhruvkb dhruvkb merged commit d14c86a into main Feb 9, 2022
@dhruvkb dhruvkb deleted the primary_pink branch February 9, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants