Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Restore Feedback page #73

Merged
merged 7 commits into from
May 31, 2021
Merged

Restore Feedback page #73

merged 7 commits into from
May 31, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented May 27, 2021

Fixes #72.

This PR restores the Feedback page that was removed in #58, with new feedback forms and de-duplicated code.

@dhruvkb dhruvkb added the 🌟 goal: addition Addition of new feature label May 27, 2021
@dhruvkb
Copy link
Member Author

dhruvkb commented May 27, 2021

Suggestions:
image

Bugs:
image

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It's only missing the menu entry in the embedded mode. In the EmbeddedNavSection component I think.

@obulat
Copy link
Contributor

obulat commented May 29, 2021

I've added the changes for the EmbeddedNavSection and the embedded page to keep it the same as other embedded mode pages.

@zackkrida
Copy link
Member

So much collaboration haha! Glad you all worked on this together 😊

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice small fixes in here too. Thanks @dhruvkb

@zackkrida zackkrida merged commit e3772e8 into develop May 31, 2021
@zackkrida zackkrida deleted the feedback branch June 1, 2021 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back the /feedback page
5 participants