Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update to new Google Forms #69

Merged
merged 1 commit into from
May 26, 2021
Merged

Update to new Google Forms #69

merged 1 commit into from
May 26, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented May 26, 2021

Fixes #66.

This PR updates the the URLs to the Google forms.

@dhruvkb dhruvkb requested review from zackkrida, krysal and obulat May 26, 2021 06:48
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to details !

@@ -29,7 +33,7 @@ export default {
computed: {
formLink() {
const location = this.location
return `https://docs.google.com/forms/d/e/1FAIpQLSeSApxNMup8Ujt-8Vjv53ngltzhJeaHspMykHCD8VKQ39yXAA/viewform?usp=pp_url&entry.1690035721=${location}`
return `${reuseForm}?entry.${imageLinkEntry}=${location}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the usp=pp_url used for? I assume it's not necessary anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the usp query param usually indicates where the request came from. In that regard, it is very similar to UTM tags.

Anyway, it didn't have any effect on the form so I dropped it.

@zackkrida zackkrida merged commit 2228157 into develop May 26, 2021
@zackkrida zackkrida deleted the updated_forms branch May 26, 2021 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all reporting forms work
4 participants