Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

All results audio tabbing, single result link, and play/pause fixes #683

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #662 by @zackkrida

Description

  • Spacebar or play button click to play/pause on boxed audio
  • Click or enter to visit single result

We probably still need to announce to screen reader users that space will play/pause and click will visit the single result. There may be a way to do what I'm doing and wrap in a NuxtLink for improved usability.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner January 21, 2022 20:41
@zackkrida zackkrida requested review from obulat and dhruvkb January 21, 2022 20:41
@@ -5,7 +5,11 @@
:type="type"
v-on="$listeners"
>
<VIcon :class="[...iconSizeClasses]" v-bind="iconProps" />
<VIcon
class="pointer-events-none"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows icon click events to pass through to their parent element, which makes sure the target of icon buttons clicks is always the button, not the internal icon.

@zackkrida zackkrida added ♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jan 21, 2022
@zackkrida zackkrida changed the title tabindex -1 on play/pause when layout is box All results audio tabbing, single result link, and play/pause fixes Jan 21, 2022
@zackkrida zackkrida merged commit f5ce564 into main Jan 21, 2022
@zackkrida zackkrida deleted the box-audio-a11y branch January 21, 2022 21:34
@zackkrida
Copy link
Member Author

Merging, even if this has problems it's still vastly preferable to the previous approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All results boxed audio a11y
1 participant