Notices for Jamendo tracks when seeking is impossible

[zackkrida]

Fixes

Fixes #680 by @zackkrida

Description

Adds a featureNotices feature to the audio track so custom messages can be displayed when any given feature isn't active. It's a bit of an extra abstraction but felt cleaner and simpler than writing some specific hack for this functionality.

a11y info

When the waveform is disabled, it is no longer focusable, so when users tab from the play button they are sent straight to the next play button. This means they are not explicitly informed about the disabled seek bar, but they're also not incorrectly able to focus the waveform or anything worse like that. I'm not sure how to best approach the ideal solution to this.

Caveats

I couldn't get our UA detection to run server-only, which I would have liked. Perhaps this could be refactored in the future to add the parsed UA information to a Vuex store instead of injecting it into the Nuxt context, which would preserve the data on client-side renders after the initial server render, but alas, I tried that and wasn't able to get it to work either. For whatever reason it seemed my mutation wouldn't run.

Testing Instructions

Visit an audio results page in Chrome or Edge and observe the hover effect on a Jamendo track.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

This is awesome, appreciate the forethought to pop features with notices! Approving with a non-blocking suggestion.

[dhruvkb]

Imo we use the existing message field, with a prop that allows it to be transient. I doubt the two will ever need to overlap.

[zackkrida]

At a minimum they could definitely share some styles; good suggestion.

[sarayourfriend]

@zackkrida I like this solution but just letting you know I'm going to take some extra time to review this on using JAWS on a Windows VM to make sure that it's a pleasant experience for screen reader users.

FWIW I think just skipping the seeking might be okay for now? I considered suggesting that we added some kind of extra information into the label on the play/pause button to indicate that seeking would be disabled for that particular audio track, but I want to be wary of the fact that if you narrowed a search to just jamendo tracks then every single play/pause button would include this extra information and could be frustrating for the user.

[zackkrida]

I'm going to take some extra time to review this on using JAWS on a Windows VM

@sarayourfriend please do, thank you 😄 Keep that VM hot for #662 later too 😆

[fcoveram]

I added a few mockups on the Releases file showing the alert message above grid results and in the wave area on both desktop and mobile. The message is primarily static on mobile, yet it shows the playing state through the yellow background.

The limited to Firefox and Safari sounds intentional instead of a condition openverse is dealing with.

[sarayourfriend]

Oh that's something I hadn't considered, how this will appear to Android Chrome users.