Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Make e2e tests pass #667

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Make e2e tests pass #667

merged 2 commits into from
Jan 21, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 21, 2022

Description

This PR is a quick fix for e2e tests failures. It does not attempt to add good tests, only make the e2e tests that were written are usable for ci.

Testing Instructions

Run

  1. pnpm run dev and pnpm run test:e2e - all the tests should pass.
  2. Stop the dev script running on port 8443 and run pnpm run e2e:ci (or trust the GitHub actions to run this :) )

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner January 21, 2022 09:12
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jan 21, 2022
@obulat obulat self-assigned this Jan 21, 2022
@obulat
Copy link
Contributor Author

obulat commented Jan 21, 2022

Merging this PR with only 1 approval to enable CI.

@obulat obulat merged commit 097dc4d into main Jan 21, 2022
@obulat obulat deleted the fix/hotfix_for_e2e branch January 21, 2022 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants