Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add the privacy policy to the menu #651

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Add the privacy policy to the menu #651

merged 1 commit into from
Jan 20, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #650 by @zackkrida

Description

Adds a link to WP.org's privacy policy to the menu.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner January 20, 2022 15:37
@sarayourfriend
Copy link
Contributor

@zackkrida did you mean to remove openverse.pot?

@zackkrida
Copy link
Member Author

Fixed, thanks @sarayourfriend! I conflated it with the various .json files we don't want to track.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be an acceptable stop-gap until we can get the footer working correctly.

@fcoveram
Copy link

Can we set a min-width for the menu popover? It looks too narrow.

CleanShot 2022-01-20 at 15 19 43@2x

A 200px width like the mockup in Views page looks good to me.

CleanShot 2022-01-20 at 15 23 15@2x

@zackkrida
Copy link
Member Author

@panchovm sure, I made a PR for that here: #658

@zackkrida zackkrida added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟧 priority: high Stalls work on the project or its dependents labels Jan 20, 2022
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! No problem, thanks.

@zackkrida zackkrida merged commit 95efd44 into main Jan 20, 2022
@zackkrida zackkrida deleted the privacy-policy branch January 20, 2022 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add privacy policy to the main menu
4 participants