Add API url changes to the e2e tests

[obulat]

Fixes

Fixes #572 by @zackkrida

Description

This PR updates the API request urls used in the e2e tests, and un-comments mocking of the request.

Testing Instructions

Run pnpm run e2e:ci. All e2e tests should pass.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[krysal]

Curiously for me the tests pass in main but fail here 😅

[zackkrida]

Still experiencing a single e2e test failure:

  1) filters.spec.js:20:1 › can unset filters using filter tags ====================================

    Error: expect(received).toEqual(expected) // deep equality

    Expected: "https://api.openverse.engineering/v1/images/?q=cat"
    Received: "https://api.openverse.engineering/v1/images/2aa643ce-d2f5-491f-9425-3ca0d86fe7e7/thumb/"

      33 |     const baseUrl = 'https://api.openverse.engineering/v1/images/'
      34 |     if (url.startsWith(baseUrl)) {
    > 35 |       expect(url).toEqual(baseUrl + '?q=cat')
         |                   ^
      36 |     }
      37 |   })
      38 |   await cc0Tag.click()

        at Page.<anonymous> (/Users/zackkrida/Code/openverse/front/test/e2e/filters.spec.js:35:19)
        at Page.emit (node:events:390:28)
        at BrowserContext._onRequestFinished (/Users/zackkrida/Code/openverse/front/node_modules/.pnpm/playwright-core@1.17.1/node_modules/playwright-core/lib/client/browserContext.js:199:20)
        at Proxy.<anonymous> (/Users/zackkrida/Code/openverse/front/node_modules/.pnpm/playwright-core@1.17.1/node_modules/playwright-core/lib/client/browserContext.js:148:56)
        at Proxy.emit (node:events:390:28)
        at Connection.dispatch (/Users/zackkrida/Code/openverse/front/node_modules/.pnpm/playwright-core@1.17.1/node_modules/playwright-core/lib/client/connection.js:208:21)
        at Immediate.<anonymous> (/Users/zackkrida/Code/openverse/front/node_modules/.pnpm/playwright-core@1.17.1/node_modules/playwright-core/lib/inProcessFactory.js:50:83)
        at processImmediate (node:internal/timers:464:21)


  1 failed
    filters.spec.js:20:1 › can unset filters using filter tags =====================================
  7 skipped
  24 passed (14s)
 ELIFECYCLE  Command failed with exit code 1.

[obulat]

I've added the question mark to the URL to check, so that only the search request is tested, not the requests for thumbs or related images. This should definitely work now :)

[zackkrida]

Yes!

[krysal]

I'm curious about the approach suggested by @dhruvkb. This solves the broken workflow so it still helps.