-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
I understand it's a bit unrelated to this PR but I'd love to have something that provides a deployment URL for every PR, similar to how Netlify and Vercel are able to do. It'll make testing PRs with UI changes so much easier. |
100% on board with that Dhruv! I'll ask around and see if anyone has opinions on how to get that done. I know it's something that the Gutenberg folks have talked about before so I'm sure they have some existing ideas about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would love to see it live!
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool to have the Storybook deployed on the main
branch! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really useful addition!
Fixes
Fixes #549 by @sarayourfriend
Description
Sets up the necessary stuff to deploy Storybook from the
gh-pages
branch by adding a new workflow for pushing to that branch on merge to main.Testing Instructions
Let the CI run on this PR and then check the
gh-pages
branch and verify that it's been created and updated.\You can also see the currently deployed version from cb81806 here: https://wordpress.github.io/openverse-frontend - after that commit I removed the testing code that was pushing to the
gh-pages
branch in this PR. From now on it will only run on merge tomain
.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin