-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
<div class="part-b inline-flex space-x-1"> | ||
<div v-if="isMedium"> | ||
<div class="part-b inline-flex"> | ||
<div v-if="isMedium" class="pe-1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space-x-
classes apply to all children as in
.space-x-1 > * + * {
margin-left: 0.25rem;
}
Replacing it with pe-
classes will mean adding it to all children except the first. Alternatively we could use gap-
classes on the flex itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving padding on the last element doesn't seem to introduce any visual problems that I could see. While not being a 1:1 replacement for space-x-*
I think it's appropriate in this case? I guess the tailwindcss-rtl plugin doesn't cover the space-<dir>-<unit>
.
gap
seems like a better solution though. I'll update to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
f93d08f
to
3f05865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Fixes #513 by @sarayourfriend
Fixes #512 by @sarayourfriend
Closes #421 as this will address the last two problems in that issue.
Description
Fixes the RTL visual bugs outlined in the issues.
Testing Instructions
Checkout this branch and run it with
npm run dev
. Then go to http://localhost:8443/audio/8071128a-bebc-4c24-823d-6e26a2e6dfe2 and verify that the two elements outlined in the issue look good in both RTL and LTR mode. Follow the instructions in this issue under the Reproduction headline for how to quickly test RTL and LTR locally.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin