Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix audio RTL visual bugs #514

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fix audio RTL visual bugs #514

merged 2 commits into from
Dec 14, 2021

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Dec 13, 2021

Fixes

Fixes #513 by @sarayourfriend
Fixes #512 by @sarayourfriend

Closes #421 as this will address the last two problems in that issue.

Description

Fixes the RTL visual bugs outlined in the issues.

Testing Instructions

Checkout this branch and run it with npm run dev. Then go to http://localhost:8443/audio/8071128a-bebc-4c24-823d-6e26a2e6dfe2 and verify that the two elements outlined in the issue look good in both RTL and LTR mode. Follow the instructions in this issue under the Reproduction headline for how to quickly test RTL and LTR locally.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Dec 13, 2021
@sarayourfriend sarayourfriend requested a review from a team as a code owner December 13, 2021 18:07
<div class="part-b inline-flex space-x-1">
<div v-if="isMedium">
<div class="part-b inline-flex">
<div v-if="isMedium" class="pe-1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-x- classes apply to all children as in

.space-x-1 > * + * {
  margin-left: 0.25rem;
}

Replacing it with pe- classes will mean adding it to all children except the first. Alternatively we could use gap- classes on the flex itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving padding on the last element doesn't seem to introduce any visual problems that I could see. While not being a 1:1 replacement for space-x-* I think it's appropriate in this case? I guess the tailwindcss-rtl plugin doesn't cover the space-<dir>-<unit>.

gap seems like a better solution though. I'll update to that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarayourfriend sarayourfriend enabled auto-merge (squash) December 13, 2021 21:33
@sarayourfriend sarayourfriend merged commit 07c1285 into main Dec 14, 2021
@sarayourfriend sarayourfriend deleted the fix/rtl-audio branch December 14, 2021 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio search result RTL issues Single result page for Audio RTL touchups RTL touchups
3 participants