This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Replace Donation Banner with a generic Notification Banner to use when necessary #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
The CC donation banner and the a/b test for its language need to be removed from the site.
This PR converts the DonationBanner into a more general component to display a site banner beneath the header navbar whenever we need that. It creates a new store to keep the state related to the notification banner.
To create and show the Notification Banner, you need to:
showNotification
in thenotification-store
state to true.header.notification.okay
in the locale file to the name of the button, and add the action that needs to be performed in theNOTIFICATION_ACTION
in thenotification-store
.Dismiss
button to have a text and not just a cross icon, add the button text toheader.notification.dismiss
key in the locale file.The test failures in the a/b experiment tests prevented me from pushing, so I fixed them, too.