-
Notifications
You must be signed in to change notification settings - Fork 63
Fix API endpoints for related media and provider stats #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests great. Hopefully we can figure out why related images are broken but at least the critical path is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with the local API, and everything works great!
I added code suggestions to remove a stray log statement and a small change.
I get the 400 error for related endpoint, it is caused by pagination error in the API: |
Co-authored-by: Olga Bulat <obulat@gmail.com>
Fixes
This PR fixes the endpoints to fetch related media, updates to use the new endpoints for provider stats, and removes fallback default provider data that was hardcoded into the repo, which can give false assurances that things are working.
We'll need to test API changes on the front-end much more closely moving forward.
Noting that in production, the related API endpoint is still seemingly broken, although my local instance of the API is working.
Description
Some additional low-hanging cleanup here:
getProviderStats
, which wouldn't actually catch exceptionsTesting Instructions
v1
at the end of the endpoint!). Confirm that locally configured sources are visible.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin