Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add progressive TypeScript compilation #503

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Add progressive TypeScript compilation #503

merged 4 commits into from
Dec 9, 2021

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fixes #175 by @sarayourfriend

Description

Replaces jsconfig.json with a tsconfig.json that mirrors Gutenberg's with some changes to accomodate not being a composite project.

Currently this only checks a single file, basically in an effort to minimize the size of this PR while also still proving that it does work as intended. I had to make a small update to the type declarations in this file to get the compiler to pass. Hooray for type feedback! 🎉

Future work will include slowly adding each file in src/composables to the include array. We can also start running the type checker on other parts of the codebase like the services 🙂 I would propose doing this in small isolated bits and pieces to avoid having to make too many changes in a single PR to address the inevitable error here and there.

Testing Instructions

Checkout the PR and run npm run types. Everything should come back without an error. Next, update use-event-listener-outside.js to include a type error. For example, add the following somewhere in the file:

/** @type {string} */
const foo = null

This is a type error becuase you can't assign null to a string. Your IDE should pick this up and give you some squiggly lines or a warning (however your IDE normally picks up compilation errors). You should now also be able to run npm run tsc and have it report back the error to you.

Go ahead and try to commit that (you'll have to disable the eslint no-unused-vars rule temporarily to be able to run the pre-commit) and pre-commit should fail on the tsc step.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Dec 8, 2021
@sarayourfriend sarayourfriend requested a review from a team as a code owner December 8, 2021 19:12
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Adding a type error produced the expected result.

@zackkrida
Copy link
Member

npm run format:test is warning on the tsconfig.json file, however...

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I tried adding use-related to the include array - and Oh wow, it's so much work :)

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major boost for DX!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra help with types is excellent! ✨

@sarayourfriend sarayourfriend merged commit c5388da into main Dec 9, 2021
@sarayourfriend sarayourfriend deleted the add/tsc branch December 9, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore adding progressive typechecking where possible
5 participants