Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update README.md to remove broken link #498

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

amm98d
Copy link
Contributor

@amm98d amm98d commented Dec 7, 2021

Fixes

Fixes #494 by @zackkrida

Description

The text in the readme "You can learn more about the migration to Nuxt.js here." links to a broken page. That has been removed.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@amm98d amm98d requested a review from a team as a code owner December 7, 2021 12:07
@amm98d amm98d requested review from zackkrida and krysal December 7, 2021 12:07
@amm98d amm98d marked this pull request as draft December 7, 2021 12:21
@amm98d amm98d marked this pull request as ready for review December 7, 2021 12:21
@amm98d
Copy link
Contributor Author

amm98d commented Dec 7, 2021

How do I add the PR labels, the ones whose checks are failing...

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zackkrida zackkrida added 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed labels Dec 7, 2021
@zackkrida
Copy link
Member

@amm98d Nice first contribution 😄 I've added the labels for you, you can do that in the sidebar of GitHub in the future:

CleanShot 2021-12-07 at 07 44 35@2x

@amm98d
Copy link
Contributor Author

amm98d commented Dec 7, 2021

@amm98d Nice first contribution 😄 I've added the labels for you, you can do that in the sidebar of GitHub in the future:

@zackkrida thanks!
That's exactly where I was looking, for some reason, I am not getting that wheel icon in the sidebar 🤷‍♂️

@zackkrida
Copy link
Member

zackkrida commented Dec 7, 2021

@amm98d So you don't need to click the wheel—it's a bit unintuitive but you have to click the word 'Labels' which then shows you a dropdown of labels 😅

But also, I think only members of the repository with the role contributor are allowed to label PRs in GitHub!

@amm98d
Copy link
Contributor Author

amm98d commented Dec 7, 2021

@amm98d So you don't need to click the wheel—it's a bit unintuitive but you have to click the word 'Labels' which then shows you a dropdown of labels 😅

But also, I think only members of the repository with the role contributor are allowed to label PRs in GitHub!

Right, makes sense. Well, thanks though!

@dhruvkb dhruvkb merged commit 2fd9269 into WordPress:main Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove broken link from README
3 participants